-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
allow multiple prerequisiteTag
s
#87
base: main
Are you sure you want to change the base?
Conversation
This comment was marked as resolved.
This comment was marked as resolved.
784d146
to
8ec3eab
Compare
thanks @tordans, I've updated the README |
8ec3eab
to
5f100f2
Compare
5f100f2
to
477597a
Compare
477597a
to
75d757e
Compare
I am wondering about two things… a. I don't think its great to have a key b. The note on breaking changes is true for iD, but it is not true for GoMap, EveryDoor and other data consumers of the tagging schema repo. I don't see any way to do a soft migration with deprecation and both solutions being present for one release cycle. That would be ideal to release fast but allow consumer apps to update afterwards. |
Are you suggesting that we allow both
Based on 544f546, it looks like there's about to be a major release, so we may as well label this as breaking It would be worth prewarning GoMap and EveryDoor, since they're both fetching directly from the main branch...12 Ideally all data consumers would be setup to only fetch Footnotes |
I think the best would be to make it a breaking change and migrate everything to
Sounds like the cleanest solution to me.
Agreed. Lets wait for Martin and then create an issue to ping the known data users. |
On the question of a mayor release and how to inform consumers of the data: @tyrasd just told me he looked into this with a breaking change in 2022 (eg. here, here). Most editors should be using a specific major release. GoMap does not, but that is fine because Bryce pulls the change manually via script so he is informed of breaking changes this way. |
75d757e
to
a6413bb
Compare
Closes #137
Relates to openstreetmap/iD#9511.
This is not a breaking change if that PR is merged first.See openstreetmap/iD#9511 for details.